fix(core): correctly set Listener.handleNewSignedBlockfrom's spanStatus from returned error or panics #3817
Conversation
odeke-em
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
==========================================
+ Coverage 44.83% 46.41% +1.57%
==========================================
Files 265 314 +49
Lines 14620 18151 +3531
==========================================
+ Hits 6555 8424 +1869
- Misses 7313 8709 +1396
- Partials 752 1018 +266 ☔ View full report in Codecov by Sentry. |
|
There is a lint issue and LGTM |
odeke-em
force-pushed
the
core-correctly-set-Span.Status
branch
from
b44a7da
to
563f827
Compare
|
Thanks @Wondertan! Kindly help me take a look again. |
odeke-em
force-pushed
the
core-correctly-set-Span.Status
branch
from
563f827
to
40598bc
Compare
…us from returned error or panics This change ensures that if a panic occurs, that span.RecordError correctly records it and then if an error is returned that span.Status correctly captures and records it. Fixes celestiaorg#3814
odeke-em
force-pushed
the
core-correctly-set-Span.Status
branch
from
40598bc
to
fbc937c
Compare
|
All checks passing, we are good to go @Wondertan |
| // Record the "exception"/panic. | ||
| span.RecordError(rerr) |
There was a problem hiding this comment.
Lets move it out of recover block and put it instead of SetStatus, while SetStatus goes to every individual error check.
As per otel API these are used together and not only on recovering. RecordError does what it says, while SetStatus has a description on it to put next to the operation.
So extendBlock would become
eds, err := extendBlock(b.Data, b.Header.Version.App)
if err != nil {
span.SetStatus(codes.Error, "extendBlock")
return fmt.Errorf("extending block data: %w", err)
}
and so on| if r != nil { // Re-panic | ||
| panic(r) | ||
| } |
There was a problem hiding this comment.
Wanted to avoid re-panicing, but actually we should so that the panic during sync doesn't go unnoticed
[not actionable]
|
@odeke-em would you be able to implement the changes requested by Hlib here or should we take over the PR from you? If we don't hear back in a week, we'll take it over. Thanks! |
|
Hey @renaynay, please feel free to take over. Thank you. |
This change ensures that if a panic occurs, that span.RecordError correctly records it and then if an error is returned that span.Status correctly captures and records it.
Fixes #3814